[CALCITE-4747] clean all outdated edges from graph.edges#2501
Merged
liyafan82 merged 1 commit intoapache:masterfrom Sep 9, 2021
Merged
[CALCITE-4747] clean all outdated edges from graph.edges#2501liyafan82 merged 1 commit intoapache:masterfrom
liyafan82 merged 1 commit intoapache:masterfrom
Conversation
Mulavar
changed the title
Contributor
|
@Mulavar Nice catch. Thank you. |
Member
Author
done. |
liyafan82
reviewed
Sep 7, 2021
Mulavar
force-pushed
the
feat/edge-clean
branch
2 times, most recently
from
fa4d4ad to
23b137e
Compare
Member
Author
|
Thank you for your suggestion, I have added a test in org.apache.calcite.util.graph.DirectedGraphTest. |
liyafan82
reviewed
Sep 8, 2021
liyafan82
reviewed
Sep 8, 2021
Contributor
@Mulavar It looks much better. Thanks for the followup. |
Mulavar
force-pushed
the
feat/edge-clean
branch
2 times, most recently
from
a8cbe73 to
9cb3845
Compare
Contributor
|
LGTM. Could you please squash the changes into a single commit? @Mulavar |
Mulavar
force-pushed
the
feat/edge-clean
branch
from
9cb3845 to
8fb09a5
Compare
Member
Author
done |
liyafan82
reviewed
Sep 8, 2021
core/src/test/java/org/apache/calcite/util/graph/DirectedGraphTest.java
Outdated
Show resolved
Hide resolved
Mulavar
force-pushed
the
feat/edge-clean
branch
from
8fb09a5 to
f7ed953
Compare
liyafan82
added
the
LGTM-will-merge-soon
Contributor
|
Merging. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.