[CALCITE-4803] AggregateProjectMergeRule lost alias after remove the …#2546
Open
xy2953396112 wants to merge 1 commit intoapache:mainfrom
Open
[CALCITE-4803] AggregateProjectMergeRule lost alias after remove the …#2546xy2953396112 wants to merge 1 commit intoapache:mainfrom
xy2953396112 wants to merge 1 commit intoapache:mainfrom
Conversation
xy2953396112
force-pushed
the
CALCITE_4803
branch
3 times, most recently
from
40ff354 to
9bcb045
Compare
chunweilei
reviewed
Oct 20, 2021
| () -> "no value found for key " + key + " in " + map)); | ||
| if (!newKeys.equals(newGroupSet.asList())) { | ||
| final List<String> newaggFieldNames = newAggregate.getRowType().getFieldNames(); | ||
| final List<String> aggFieldNames = aggregate.getRowType().getFieldNames(); |
Contributor
There was a problem hiding this comment.
newaggFieldNames -> newAggFieldNames?
Contributor
Author
There was a problem hiding this comment.
newaggFieldNames -> newAggFieldNames?
ok, thanks.
Contributor
Author
There was a problem hiding this comment.
newaggFieldNames -> newAggFieldNames?
I updated the code. Please help review again.Thanks.
chunweilei
added
the
LGTM-will-merge-soon
…Project operator (xzh)
xy2953396112
force-pushed
the
CALCITE_4803
branch
from
9bcb045 to
c045698
Compare
Contributor
|
Before merge this PR. I think maybe we should reach an agreement in Jira. Because this will be exists confuse in the future.(The code implement is different about the design) |
chunweilei
added
discussion-in-jira
Contributor
Thank you for your kindly reminder. Let us discuss in jira. |
julianhyde
force-pushed
the
main
branch
2 times, most recently
from
8a5cf83 to
cf7f71b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Project operator (xzh)
https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4803