[CALCITE-4232] Support IN query in elasticsearch adapters#2551
Open
shlok7296 wants to merge 1 commit intoapache:mainfrom
Open
[CALCITE-4232] Support IN query in elasticsearch adapters#2551shlok7296 wants to merge 1 commit intoapache:mainfrom
shlok7296 wants to merge 1 commit intoapache:mainfrom
Conversation
shlok7296
changed the title
zabetak
requested changes
Oct 4, 2021
Member
zabetak
left a comment
zabetak
left a comment
There was a problem hiding this comment.
This seems to be a new feature so tests are definitely needed in order for this to get merged to master.
| case OR: | ||
| case LIKE: | ||
| case EQUALS: | ||
| case IN: |
Member
There was a problem hiding this comment.
If I remember well the IN operator has been superseded by SEARCH so this code may be unreachable at the moment.
julianhyde
force-pushed
the
main
branch
2 times, most recently
from
8a5cf83 to
cf7f71b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.