[CALCITE-4844] IN-list that references columns is wrongly converted to Values, and gives incorrect results#2594
Merged
Merged
Conversation
NobiGo
changed the title
zinking
reviewed
Nov 2, 2021
| && (Boolean) value; | ||
| closer.add(Prepare.THREAD_EXPAND.push(b)); | ||
| } | ||
| if (propertyName.equals("insubquerythreshold")) { |
Contributor
There was a problem hiding this comment.
is this temporary ? surprised code gen part follows naturely and requires no change.
Contributor
Author
There was a problem hiding this comment.
No. This can be used in the .iq file to set the insubquerythreshold property.
Contributor
Author
There was a problem hiding this comment.
!set insubquerythreshold 0
Contributor
Author
There was a problem hiding this comment.
@zinking Please review again, Then we can merge.
…o Values, and gives incorrect results
NobiGo
added
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o Values, and gives incorrect results