[CALCITE-4914] Introduce HandlerBasedRelMetdataQuery as an extension point#2624
Closed
jacques-n wants to merge 3 commits into
Closed
[CALCITE-4914] Introduce HandlerBasedRelMetdataQuery as an extension point#2624jacques-n wants to merge 3 commits into
jacques-n wants to merge 3 commits into
Conversation
…point This is a precursor to implementing CALCITE-4879. It tries to better encapsulate separate the consumption side of RelMetaDataQuery from the production side. This includes: - Mark the public fields in RelMetadataQueryBase as INTERNAL fields - Deprecate the static initialHandler method and replace it with a class level createInitialHandler - Deprecate the public constructor of RelMetadataQuery to avoid direct extension - Introduce a new HandlerBasedRelMetdataQuery that will house the handler specific concepts in a future release.
Contributor
Author
|
Adding @julianhyde as a reviewer as he expressed some concerns around this work on Jira. |
Contributor
Author
|
Due to discussions on jira, abandoning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a precursor to implementing CALCITE-4879. It tries to better encapsulate/separate
the consumption side of RelMetaDataQuery from the production side. This includes:
concepts in a future release.