Closed
Conversation
It is not possible to use a range distribution with the current assert, it will always fail.
chunweilei
reviewed
Dec 10, 2021
| || type == Type.RANDOM_DISTRIBUTED | ||
| || type == Type.RANGE_DISTRIBUTED | ||
| || keys.isEmpty(); | ||
| } |
Contributor
There was a problem hiding this comment.
@rendel Thank you for reporting this. I think it is a bug. Could you file a JIRA for this?
Contributor
There was a problem hiding this comment.
I would say a test case is more important than JIRA.
If the assertion is user-facing, then it should be a regular if + illegalargumentexception
chunweilei
added
the
needs-a-final-review
Contributor
|
BTW, you can find more details about contribution in the doc[1]. |
Contributor
|
Let us move to #2822. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not possible to use a range distribution with the current assert, it will always fail.