[CALCITE-4952] (Re)introduce a simplistic RelMetadataQuery option#2653
Merged
jacques-n merged 1 commit intoapache:masterfrom Dec 29, 2021
Merged
Conversation
Contributor
jacques-n
commented
Dec 19, 2021
- Introduce new ProxyingMetadataHandlerProvider that avoids code compilation
- Update RelMetadataTest to factor out metadata handling from tests
- Introduce tests for both Janino and the proxying/simplistic path.
- A simple microbenchmark for metadata
- Minor version bump to JMH
- Enable clearing of static cache within JaninoRelMetadataProvider
1c9882b to
751b4ba
Compare
zabetak
reviewed
Dec 20, 2021
core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
Outdated
Show resolved
Hide resolved
jamesstarr
reviewed
Dec 20, 2021
zabetak
reviewed
Dec 22, 2021
ubenchmark/src/jmh/java/org/apache/calcite/benchmarks/MetadataBenchmark.java
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/rel/metadata/ProxyingMetadataHandlerProvider.java
Show resolved
Hide resolved
82f0fb2 to
dab46af
Compare
- Introduce new ProxyingMetadataHandlerProvider that avoids code compilation - Update RelMetadataTest to factor out metadata handling from tests - Introduce tests for both Janino and the proxying/simplistic path. - A simple microbenchmark for metadata - Minor version bump to JMH - Enable clearing of static cache within JaninoRelMetadataProvider - Update RelMetadataTest to be parameterized - Add test to confirm cyclic exception
dab46af to
df35274
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.