[CALCITE-4954] Group TEXT field failed in Elasticsearch Adapter#2695
Merged
mihaibudiu merged 1 commit intoapache:mainfrom Dec 5, 2024
Merged
[CALCITE-4954] Group TEXT field failed in Elasticsearch Adapter#2695mihaibudiu merged 1 commit intoapache:mainfrom
mihaibudiu merged 1 commit intoapache:mainfrom
Conversation
julianhyde
force-pushed
the
main
branch
2 times, most recently
from
8a5cf83 to
cf7f71b
Compare
Contributor
|
This seems to have been approved more than 1 year ago, so if @ILuffZhe can squash the commits we can merge it? |
ILuffZhe
force-pushed
the
CALCITE-4954
branch
from
53db1f6 to
102beda
Compare
|
Contributor
Author
|
@mihaibudiu Sorry for the delay, I've rebased this PR, please take a look when you are free. |
mihaibudiu
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set "fielddata" to "true" in Elasticsearch mapping, since aggregations and sorting are disabled by default for text type.
It's only set in the test module, which provides instruction for SQL users when they want to group or sort text field.