Following [CALCITE-1794], update DruidDateTimeUtils and plans in Druid adapter#2736
Merged
NobiGo merged 1 commit intoapache:masterfrom Mar 3, 2022
Merged
Following [CALCITE-1794], update DruidDateTimeUtils and plans in Druid adapter#2736NobiGo merged 1 commit intoapache:masterfrom
NobiGo merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@zabetak Hi. Sorry to bother you. I omit the Druid Adapter test when merging CALCITE-1794. I am not familiar with this module, So if you have free time, Please review it. Thanks. |
zabetak
approved these changes
Mar 3, 2022
Member
zabetak
left a comment
zabetak
left a comment
There was a problem hiding this comment.
The new plans look good to me and in some cases they are much more efficient than the old plans. Well done @NobiGo !
Minor thing when you commit please indicate the relation with CALCITE-1794. See previous commit messages e.g:
Following [CALCITE-1794], update DruidDateTimeUtils and plans in Druid adapter
NobiGo
force-pushed
the
Druid_Adapter_test
branch
from
34c61e1 to
538faf6
Compare
NobiGo
changed the title
Contributor
Author
|
Thanks for the review @zabetak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.