[CALCITE-5029] Babel parser support identifier starting with number#2737
Closed
wojustme wants to merge 1 commit intoapache:mainfrom
Closed
[CALCITE-5029] Babel parser support identifier starting with number#2737wojustme wants to merge 1 commit intoapache:mainfrom
wojustme wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
Define a plugin in parser.jj for custom identifier token, and rewrite it in babel's parser.
Contributor
|
Would you please |
Contributor
|
What the status of current PR ? I see that PR was created almost 1 year ago and last review comment was 3 weeks ago. |
jhugomoore
pushed a commit
to jhugomoore/calcite-jhugomoore
that referenced
this pull request
Jun 21, 2023
… table names to contain dollar sign, letters with diacritical marks and non-Latin letters Co-authored-by: xurenhe <xurenhe19910131@gmail.com> Close apache#3215 Close apache#2737
jhugomoore
pushed a commit
to jhugomoore/calcite-jhugomoore
that referenced
this pull request
Jun 22, 2023
… table names to contain dollar sign, letters with diacritical marks and non-Latin letters Co-authored-by: xurenhe <xurenhe19910131@gmail.com> Close apache#3215 Close apache#2737
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define a plugin in parser.jj for custom identifier token, and rewrite it in babel's parser.