Skip to content

[CALCITE-5038] Making AGGREGATE_ANY_PULL_UP_CONSTANTS's test cases more rigorous#2742

Closed
wojustme wants to merge 1 commit intoapache:masterfrom
wojustme:issue_5038
Closed

[CALCITE-5038] Making AGGREGATE_ANY_PULL_UP_CONSTANTS's test cases more rigorous#2742
wojustme wants to merge 1 commit intoapache:masterfrom
wojustme:issue_5038

Conversation

@wojustme
Copy link
Contributor

@wojustme wojustme commented Mar 10, 2022

Copy link
Member

@hsyuan hsyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wojustme
Copy link
Contributor Author

@hsyuan Thanks for reviewing this pr.

@wojustme
Copy link
Contributor Author

Hi @hsyuan
Are there any deficiencies in this pr?
Could you merge it?
Thanks a lot.

Copy link
Contributor

@NobiGo NobiGo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why just change the column? I am curious

@wojustme
Copy link
Contributor Author

@NobiGo
The sales.emp's field of sal is not-null, the condition of sal is null always return FALSE in these cases.
Extracting the constants will fail, after simplifying rexnode
So, this test case may be not rigorous.

@wojustme
Copy link
Contributor Author

These changes have been integrated into PR-2743
I close it.

@wojustme wojustme closed this Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants