[CALCITE-5083] In RelBuilder.project_, do not unwrap SARGs (Vladimir Ozerov)#2762
Merged
devozerov merged 1 commit intoapache:masterfrom Apr 12, 2022
devozerov:CALCITE-5083
Merged
[CALCITE-5083] In RelBuilder.project_, do not unwrap SARGs (Vladimir Ozerov)#2762devozerov merged 1 commit intoapache:masterfrom devozerov:CALCITE-5083
devozerov merged 1 commit intoapache:masterfrom
devozerov:CALCITE-5083
Conversation
asolimando
approved these changes
Apr 6, 2022
Member
asolimando
left a comment
asolimando
left a comment
There was a problem hiding this comment.
LGTM @devozerov, nice catch!
Member
|
Can we re-trigger tests since the Calcite/Avatica integration tests did not fully run? You can achieve that via an empty commit. |
Contributor
|
Can you also add a test in RelBuilderTest? |
Member
Author
|
@asolimando done. @julianhyde the test has been added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See [1] and [2] for the context.
[1] https://lists.apache.org/thread/chwjcrdb760xbrgtx534008kpqoxbdvp
[2] https://issues.apache.org/jira/browse/CALCITE-5083