Skip to content

[CALCITE-5107] Support SQL hint for Filter, SetOp, Sort, Window, Values#2775

Closed
godfreyhe wants to merge 5 commits intoapache:masterfrom
godfreyhe:CALCITE-5107
Closed

[CALCITE-5107] Support SQL hint for Filter, SetOp, Sort, Window, Values#2775
godfreyhe wants to merge 5 commits intoapache:masterfrom
godfreyhe:CALCITE-5107

Conversation

@godfreyhe
Copy link
Copy Markdown
Contributor

Currently, only part of RelNodes support SQL hint, such as: Scan, Project, Join. Filter, SetOp, Sort, Window, Values do not support hint yet, which cause hint propagation can not be supported. This pr aims to support those nodes

RelCollation collation,
@Nullable RexNode offset,
@Nullable RexNode fetch) {
super(cluster, traits, child);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, overall looks good, there are some compile failure, can you fix that ?

@godfreyhe
Copy link
Copy Markdown
Contributor Author

cc @danny0405

Copy link
Copy Markdown
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@danny0405 danny0405 closed this in c98171d Apr 25, 2022
@godfreyhe godfreyhe deleted the CALCITE-5107 branch April 26, 2022 07:00
aymeric-dispa pushed a commit to aymeric-dispa/calcite that referenced this pull request Jul 23, 2022
tanclary pushed a commit to tanclary/calcite that referenced this pull request Nov 11, 2022
tanclary pushed a commit to tanclary/calcite that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants