[CALCITE-5217] Add support for INTERVAL qualifier for Firebolt#2860
Merged
jbalint merged 2 commits intoapache:mainfrom Nov 29, 2022
Merged
Conversation
aymeric-dispa
force-pushed
the
feature/add-support-for-interval-firebolt
branch
2 times, most recently
from
1a4c899 to
6b32974
Compare
| writer.print("-"); | ||
| } | ||
| writer.literal(interval.getIntervalLiteral()); | ||
| writer.print(interval.getIntervalQualifier().toString()); |
Contributor
There was a problem hiding this comment.
toString is AnsiSqlDialect.DEFAULT.
I prefer to use interval.getIntervalQualifier().unparse(writer, leftPrec, rightPrec);
Contributor
Author
There was a problem hiding this comment.
I just realised that the implementation was a bit too simplistic and was not handling ranges (I just pushed a change)
aymeric-dispa
force-pushed
the
feature/add-support-for-interval-firebolt
branch
3 times, most recently
from
38763ca to
7a657c5
Compare
aymeric-dispa
force-pushed
the
feature/add-support-for-interval-firebolt
branch
from
7a657c5 to
1e54206
Compare
aymeric-dispa
force-pushed
the
feature/add-support-for-interval-firebolt
branch
from
1e54206 to
30dc09a
Compare
aymeric-dispa
force-pushed
the
feature/add-support-for-interval-firebolt
branch
from
30dc09a to
3f0a888
Compare
jbalint
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the INTERVAL qualifier for Firebolt.
Ticket: https://issues.apache.org/jira/browse/CALCITE-5217