[CALCITE-5265] Select operator' parentheses should be same with Union operator#2910
[CALCITE-5265] Select operator' parentheses should be same with Union operator#2910l4wei wants to merge 3 commits into
Conversation
| /** Test case for | ||
| * <a href="https://issues.apache.org/jira/browse/CALCITE-5265">[CALCITE-5265] | ||
| * Select operator' parentheses should be same with Union operator</a>. */ | ||
| @Test void testInsertValueWithDynamicParams() { |
There was a problem hiding this comment.
Are there any tests which cover what Julian has mentioned in the JIRA comment?
There was a problem hiding this comment.
There are many unit tests cover "insert into aTable select ? from bTable" in SqlParserTest.java. And RelToSqlConverterTest::testInsertValuesWithDynamicParams will cover "insert into aTable select ? from bTable union all select ? from cTable" mentioned by Julian in JIRA comment.
|
|
||
| /** Test case for | ||
| * <a href="https://issues.apache.org/jira/browse/CALCITE-5265">[CALCITE-5265] | ||
| * Select operator' parentheses should be same with Union operator</a>. */ |
There was a problem hiding this comment.
The comment should also be adapted according to the changes in JIRA title.
|
@l4wei I didn't notice Julian has another comment when I commented with "LGTM", could you add another test which addresses Julian's comment? |
|
OK |
|
I have added test that mentioned by Julian' last comment in third commit in this PR. FYI |
…ound SELECT in INSERT
libenchao
left a comment
libenchao
left a comment
There was a problem hiding this comment.
LGTM, will merge in 24 hours if there is no more objections appear.
…ound SELECT in INSERT This closes apache#2910
…ound SELECT in INSERT This closes apache#2910
2 participants
remove necessary parentheses on select clause.