[CALCITE-2989] Use ISO calendar system when converting from java.sql.Date/Time/Timestamp to a unix timestamp#2972
Closed
freastro wants to merge 3 commits intoapache:mainfrom
Closed
Conversation
…Date/Time/Timestamp to a unix timestamp
Author
|
Will reopen targeting the CALCITE-5414 JIRA issue instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the unix timestamp to Date/Time/Timestamp conversion in
SqlFunctionsto convert between the ISO calendar system and the standard Gregorian calendar. This ensures that unix timestamps created bySqlFunctionswill have the same value as unix timestamps created byDateTimeUtils.Some of the tests may fail without this corresponding change to Avatica:
apache/calcite-avatica#197