[CALCITE-5392] Support Snapshot in RelMdExpressionLineage#2976
Merged
asolimando merged 1 commit intoapache:mainfrom Nov 22, 2022
Merged
[CALCITE-5392] Support Snapshot in RelMdExpressionLineage#2976asolimando merged 1 commit intoapache:mainfrom
asolimando merged 1 commit intoapache:mainfrom
Conversation
asolimando
approved these changes
Nov 21, 2022
Member
asolimando
left a comment
asolimando
left a comment
There was a problem hiding this comment.
LGTM, just a minor comment
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java
Show resolved
Hide resolved
JiajunBernoulli
force-pushed
the
CALCITE-5392
branch
from
488cca4 to
9e7040a
Compare
Member
|
@JiajunBernoulli, until the review process is over please don't force-push, it destroys the "link" to the old comments and it makes incremental reviewing impossible (checking just the delta from the latest review). In this case the PR is small-sized, but let's avoid it anyway to avoid encouraging this habit |
Contributor
Author
|
Sorry, I'll pay attention later. |
asolimando
reviewed
Nov 21, 2022
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java
Show resolved
Hide resolved
asolimando
added
the
LGTM-will-merge-soon
Member
|
@JiajunBernoulli it's good to me, if you can squash to a single commit I will merge, thanks! |
Co-authored-by: Alessandro Solimando <alessandro.solimando@gmail.com>
JiajunBernoulli
force-pushed
the
CALCITE-5392
branch
from
97b3ce1 to
1bd98f2
Compare
Contributor
Author
|
@asolimando Thank you again, I squashed to a single commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.