[CALCITE-5468] SqlToRelConverter throws if ORDER BY contains IN#3022
Merged
dssysolyatin merged 1 commit intoapache:mainfrom Feb 14, 2023
Merged
[CALCITE-5468] SqlToRelConverter throws if ORDER BY contains IN#3022dssysolyatin merged 1 commit intoapache:mainfrom
dssysolyatin merged 1 commit intoapache:mainfrom
Conversation
dssysolyatin
force-pushed
the
CALCITE-5468
branch
3 times, most recently
from
cbf189d to
3333ddd
Compare
dssysolyatin
changed the title
dssysolyatin
changed the title
dssysolyatin
force-pushed
the
CALCITE-5468
branch
2 times, most recently
from
3629b60 to
47ad8d1
Compare
julianhyde
reviewed
Jan 9, 2023
| + "ORDER BY\n" | ||
| + "CASE WHEN empno IN (1,2) THEN 0 ELSE 1 END"; | ||
| sql(sql).ok(); | ||
| } |
Contributor
There was a problem hiding this comment.
Don't put stuff on the end. It causes merge conflicts. Put it in the most logical place.
Contributor
There was a problem hiding this comment.
This IN is not a subquery. Can you rename this test, and add a test for a subquery?
Contributor
Author
There was a problem hiding this comment.
Yes, IN is not subquery in terms of SQL. But inside codebase there are places with code like:
/**
* Scalar expression that represents an IN, EXISTS or scalar sub-query.
*/
public class RexSubQuery extends RexCall
It is actually quite confusing.
I renamed test and added test for subquery.
dssysolyatin
changed the title
Contributor
Author
|
@julianhyde Can I merge this PR ? Or there is any objections ? |
Contributor
|
@dssysolyatin Looks good. Go ahead and merge to main. |
dssysolyatin
force-pushed
the
CALCITE-5468
branch
from
b31306a to
4140bc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.