Skip to content

[CALCITE-5446] Adding support for aliasing TIMESTAMP -> TIMESTAMP_WITH_LOCAL_TIMEZONE for BQ connections#3037

Closed
olivrlee wants to merge 6 commits intoapache:mainfrom
olivrlee:5446/timestamp_with_local_timezone_in_jdbc
Closed

[CALCITE-5446] Adding support for aliasing TIMESTAMP -> TIMESTAMP_WITH_LOCAL_TIMEZONE for BQ connections#3037
olivrlee wants to merge 6 commits intoapache:mainfrom
olivrlee:5446/timestamp_with_local_timezone_in_jdbc

Conversation

@olivrlee
Copy link
Contributor

@olivrlee olivrlee commented Jan 20, 2023 •
edited
Loading

Adding in handling and type resolution for TIMESTAMP_WITH_LOCAL_TIMEZONE if the alias is set during connection

@olivrlee olivrlee force-pushed the 5446/timestamp_with_local_timezone_in_jdbc branch 3 times, most recently from 8cde21c to bb31116 Compare January 24, 2023 00:17
@olivrlee olivrlee marked this pull request as ready for review January 24, 2023 23:23
julianhyde and others added 4 commits January 26, 2023 01:34
@julianhyde @olivrlee
start [CALCITE-5424] custom literals
3b865f6 
Add DATETIME, TIMESTAMP WITH LOCAL TIME;
add class SqlUnknownLiteral;
defer validation of character string
@julianhyde @olivrlee
more types
10122fd
@olivrlee
done for timestamp_with_local_timezone
553e28b
@julianhyde @olivrlee
start [CALCITE-5446] Support TIMESTAMP WITH LOCAL TIME ZONE type in J…
588c9db 
…DBC driver
@olivrlee olivrlee force-pushed the 5446/timestamp_with_local_timezone_in_jdbc branch 2 times, most recently from c6053b2 to e0c0cfe Compare January 26, 2023 01:55
julianhyde
julianhyde reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@julianhyde julianhyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some minor changes.

Can you revise the summary so that it describes the feature being added? It's nothing to do with JDBC, much more to do with https://issues.apache.org/jira/browse/CALCITE-5424.

The change was a bit confusing to review because the second commit negates the first. They could both have been squashed out.

@olivrlee olivrlee force-pushed the 5446/timestamp_with_local_timezone_in_jdbc branch from 7a5ed32 to 0ffe04b Compare January 27, 2023 02:38
@olivrlee olivrlee changed the title [CALCITE-5446] TIMESTAMP_WITH_LOCAL_TIMEZONE in JDBC [CALCITE-5446] Adding support for aliasing TIMESTAMP -> TIMESTAMP_WITH_LOCAL_TIMEZONE for BQ connections Jan 27, 2023
@olivrlee olivrlee force-pushed the 5446/timestamp_with_local_timezone_in_jdbc branch from 6b7c963 to 7db169d Compare January 27, 2023 03:18
@olivrlee olivrlee force-pushed the 5446/timestamp_with_local_timezone_in_jdbc branch from 7db169d to 7bd1194 Compare January 27, 2023 17:51
@olivrlee
Copy link
Contributor Author

olivrlee commented Jan 27, 2023

is there a way for me to be able to re-trigger tests? I see rerun available on my fork but not here

@asolimando
Copy link
Member

asolimando commented Jan 27, 2023

@olivrlee, if I click on the "Details" link, then I can see the "re-run" option (both globally and individually per each task), but being a committer I don't know if I can see it for this reason.

Anyway, I have restarted the failed checks for you, hth.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@olivrlee olivrlee closed this Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julianhyde julianhyde julianhyde left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olivrlee @asolimando @julianhyde @wnob