[CALCITE-5501] SqlToRelConverterTest.checkActualAndReferenceFiles fai…#3049
Merged
asolimando merged 1 commit intoapache:mainfrom Feb 10, 2023
Conversation
…ls intermittently in Jenkins CI Use the 'ResourceLock' JUnit5's annotation to force sequential execution of SqlToRelConverterTest and SqlToRelConverterExtendedTest test classes which have a race condition over SqlToRelConverterTest.xml file
asolimando
force-pushed
the
main-CALCITE-5501-fix_sqltorelconverterextededtest_flaky
branch
from
b77b68e to
765a53f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
clesaec
approved these changes
Jan 30, 2023
Contributor
clesaec
left a comment
clesaec
left a comment
There was a problem hiding this comment.
LGTM, didn't know about JUnit5 ResourceLock 👍
asolimando
deleted the
main-CALCITE-5501-fix_sqltorelconverterextededtest_flaky
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ls intermittently in Jenkins CI
The PR addresses a race condition over the shared file
SqlToRelConverterTest.xmlby enforcing a lock betweenSqlToRelConverterTestandSqlToRelConverterExtendedTestclasses.The tests within the two classes, and with respect to any other test class, remain parallel, so no test runtime drop is expected.