Site: Add Jiajun Xie as committer#3064
Merged
JiajunBernoulli merged 1 commit intoapache:mainfrom Feb 12, 2023
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
libenchao
reviewed
Feb 11, 2023
Member
libenchao
left a comment
libenchao
left a comment
There was a problem hiding this comment.
Looks great, I left one nit comment.
| githubId: jcamachor | ||
| org: Hortonworks | ||
| role: PMC | ||
| - name: Jiajun Xie |
Member
There was a problem hiding this comment.
Would you mind to also add pronouns section like
calcite/site/_data/contributors.yml
Line 51 in 0dcf3ab
Contributor
Author
There was a problem hiding this comment.
Thanks for your review.
Most people didn't add pronouns, I prefer to be the same as most people.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.