[CALCITE-5532] CompositeOperandTypeChecker should check operands without type coercion first#3070
Merged
dssysolyatin merged 1 commit intoapache:mainfrom Oct 28, 2024
Conversation
dssysolyatin
force-pushed
the
bug/fix-composite-operand-type-checker
branch
from
ca7785a to
9750754
Compare
|
Kudos, SonarCloud Quality Gate passed! |
rubenada
added
the
returned-with-feedback
julianhyde
force-pushed
the
main
branch
2 times, most recently
from
8a5cf83 to
cf7f71b
Compare
…out type coercion first
dssysolyatin
force-pushed
the
bug/fix-composite-operand-type-checker
branch
from
9750754 to
319915a
Compare
|
mihaibudiu
reviewed
Oct 24, 2024
| if (!callBinding.isTypeCoercionEnabled()) { | ||
| return false; | ||
| } | ||
| SqlCallBinding sqlBindingWithoutTypeCoercion = |
Contributor
There was a problem hiding this comment.
why do you need to create a new call binding?
callBinding does not have type coercion enabled
Contributor
Author
There was a problem hiding this comment.
@mihaibudiu That is not true. Even if you look at the if statement above:
if (!callBinding.isTypeCoercionEnabled()) {
return false;
}
if callBinding.isTypeCoercionEnabled() were false, as you suggested, then checkWithoutTypeCoercion() would always return false.
mihaibudiu
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.