[CALCITE-5563] Reduce loops to optimize RelSubset#getParents and RelSubset#getParentSubsets#3098
Merged
rubenada merged 1 commit intoapache:mainfrom Apr 21, 2023
Merged
Conversation
asdfgh19
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
@asdfgh19 Thanks for this improvement! |
rubenada
added
the
LGTM-will-merge-soon
…ubset#getParentSubsets
|
Kudos, SonarCloud Quality Gate passed! |
Author
|
@rubenada Thanks for reviewing the code! |
rubenada
changed the title
This was referenced Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: CALCITE-5563
Once we have found a matching Relsubset from its parent input, we can immediately end the inner loop