CALCITE-5624: add parser option to skip array constructor#3137
Closed
MasseGuillaume wants to merge 2 commits intoapache:mainfrom
Closed
CALCITE-5624: add parser option to skip array constructor#3137MasseGuillaume wants to merge 2 commits intoapache:mainfrom
MasseGuillaume wants to merge 2 commits intoapache:mainfrom
Conversation
for example in spark the array constructor is defined using a buildtin function: array(1, 2, 3)
Contributor
Author
|
Hum I don't think it's enough to parse, I will work on a unit test. It's probably tokenizing the stack trace |
Contributor
Author
Okay I figured it out, I just needed to add the token |
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
Following the discussion here: I'm reworking this PR at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for example in Apache Spark the array constructor is defined using a buildtin function:
array(1, 2, 3)
I don't think there is an easy way to test parser freemarker options, alternatively, I could implement this using SqlParser.Config.