CALCITE-5648 SqlDelegatingConformance incorrectly delegates to SqlConformanceEnum.DEFAULT#3152
Closed
adamkennedy wants to merge 1 commit intoapache:mainfrom
Closed
CALCITE-5648 SqlDelegatingConformance incorrectly delegates to SqlConformanceEnum.DEFAULT#3152adamkennedy wants to merge 1 commit intoapache:mainfrom
adamkennedy wants to merge 1 commit intoapache:mainfrom
Conversation
…all methods (and will break in future if new methods are added and it isn't update). Fixed expectations in the test script, but otherwise did not change anything in the tests because none of the tests covered a method that changed in a way that didn't accidentally match the DEFAULT value.
libenchao
approved these changes
Apr 17, 2023
Member
libenchao
left a comment
libenchao
left a comment
There was a problem hiding this comment.
+1, merging. @adamkennedy Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes SqlDelegatingConformance a true delegation class that delegates all methods (and will break in future if new methods are added and it isn't update). Fixed a type expectation in the test script, but otherwise did not change anything in the tests because none of the tests covered the methods changing in a way that was a mismatch for the DEFAULT value.
With this change accidental oversights that fail to implement missing delegation methods cannot happen.