[CALCITE-5705] Generalize RemoveEmptySingleRule to work with arbitrary relations and pruning configurations#3205
Closed
zabetak wants to merge 1 commit intoapache:mainfrom
Closed
Conversation
…y relations and pruning configurations 1. Remove cast to `SingleRel` inside `RemoveEmptySingleRule#onMatch` to allow the rule to transform arbitrary relations (such as `Correlate`) to empty. 2. Change `RemoveEmptySingleRule` constructor to accept `PruneEmptyRule.Config` instead of `RemoveEmptySingleRuleConfig` to be able to instatiate the rule from any kind of pruning configuration that aims to tranform a relation to empty. 3. Refactor `CorrelateLeftEmptyRuleConfig`, `ZeroMaxRowsRuleConfig` and `SortFetchZeroRuleConfig` to use `RemoveEmptySingleRule` and remove duplicate code.
zabetak
force-pushed
the
empty-single-rule-generalization
branch
from
9583fda to
66ac266
Compare
|
Kudos, SonarCloud Quality Gate passed! |
jhugomoore
pushed a commit
to jhugomoore/calcite-jhugomoore
that referenced
this pull request
Jun 21, 2023
…y relations and pruning configurations 1. Remove cast to `SingleRel` inside `RemoveEmptySingleRule#onMatch` to allow the rule to transform arbitrary relations (such as `Correlate`) to empty. 2. Change `RemoveEmptySingleRule` constructor to accept `PruneEmptyRule.Config` instead of `RemoveEmptySingleRuleConfig` to be able to instatiate the rule from any kind of pruning configuration that aims to tranform a relation to empty. 3. Refactor `CorrelateLeftEmptyRuleConfig`, `ZeroMaxRowsRuleConfig` and `SortFetchZeroRuleConfig` to use `RemoveEmptySingleRule` and remove duplicate code. Close apache#3205
jhugomoore
pushed a commit
to jhugomoore/calcite-jhugomoore
that referenced
this pull request
Jun 22, 2023
…y relations and pruning configurations 1. Remove cast to `SingleRel` inside `RemoveEmptySingleRule#onMatch` to allow the rule to transform arbitrary relations (such as `Correlate`) to empty. 2. Change `RemoveEmptySingleRule` constructor to accept `PruneEmptyRule.Config` instead of `RemoveEmptySingleRuleConfig` to be able to instatiate the rule from any kind of pruning configuration that aims to tranform a relation to empty. 3. Refactor `CorrelateLeftEmptyRuleConfig`, `ZeroMaxRowsRuleConfig` and `SortFetchZeroRuleConfig` to use `RemoveEmptySingleRule` and remove duplicate code. Close apache#3205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove cast to
SingleRelinsideRemoveEmptySingleRule#onMatchto allow the rule to transform arbitrary relations (such asCorrelate) to empty.Change
RemoveEmptySingleRuleconstructor to acceptPruneEmptyRule.Configinstead ofRemoveEmptySingleRuleConfigto be able to instatiate the rule from any kind of pruning configuration that aims to tranform a relation to empty.Refactor
CorrelateLeftEmptyRuleConfig,ZeroMaxRowsRuleConfigandSortFetchZeroRuleConfigto useRemoveEmptySingleRuleand remove duplicate code.