Skip to content

[CALCITE-5713] Update Operator's operands to ensure consistency with the latest operandList references#3213

Open
gleonSun wants to merge 1 commit intoapache:mainfrom
ApacheOrgs:CALCITE-5713
Open

[CALCITE-5713] Update Operator's operands to ensure consistency with the latest operandList references#3213
gleonSun wants to merge 1 commit intoapache:mainfrom
ApacheOrgs:CALCITE-5713

Conversation

@gleonSun
Copy link

The SqlBasicCall#set method uses a deep copy in order to modify immutable collections and returns a new operandList object when modified.

If the SQL contains an operation that requires a rewrite call, the deep copy logic will cause the operator and operandList to be different and eventually raise an exception.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

92.3% 92.3% Coverage
0.0% 0.0% Duplication

@julianhyde julianhyde force-pushed the main branch 2 times, most recently from 8a5cf83 to cf7f71b Compare June 8, 2023 21:21
@JiajunBernoulli JiajunBernoulli added the discussion-in-jira There's open discussion in JIRA to be resolved before proceeding with the PR label Jun 10, 2023
@gleonSun gleonSun changed the title [CALCITE-5713] SqlBasicCall#setOperand no longer uses deep copy to modify collection elements [CALCITE-5713] Update Operator's operands to ensure consistency with the latest operandList references Jul 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions.

@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions.

@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 30, 2025
@github-actions github-actions bot removed the stale label Sep 8, 2025
@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 30, 2025
@github-actions github-actions bot removed the stale label Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussion-in-jira There's open discussion in JIRA to be resolved before proceeding with the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants