Skip to content

[MINOR] Assert can be replaced in AbstractMaterializedViewRule#perform() #3259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JiajunBernoulli merged 1 commit into from
Jun 29, 2023
Merged

[MINOR] Assert can be replaced in AbstractMaterializedViewRule#perform() #3259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ protected void perform(RelOptRuleCall call, @Nullable Project topProject, RelNod
currQEC, queryPreds, queryBasedVEC, viewPreds,
queryToViewTableMapping);
if (compensationPreds == null && config.generateUnionRewriting()) {
// Attempt partial rewriting using union operator. This rewriting
// a. Attempt partial rewriting using union operator. This rewriting
// will read some data from the view and the rest of the data from
// the query computation. The resulting predicates are expressed
// using {@link RexTableInputRef} over the view.
Expand All @@ -379,8 +379,11 @@ protected void perform(RelOptRuleCall call, @Nullable Project topProject, RelNod
}
RexNode compensationColumnsEquiPred = compensationPreds.left;
RexNode otherCompensationPred = compensationPreds.right;
assert !compensationColumnsEquiPred.isAlwaysTrue()
|| !otherCompensationPred.isAlwaysTrue();
if (compensationColumnsEquiPred.isAlwaysTrue()
&& otherCompensationPred.isAlwaysTrue()) {
// Skip it
continue;
}

// b. Generate union branch (query).
final RelNode unionInputQuery =
Expand Down Expand Up @@ -419,7 +422,7 @@ protected void perform(RelOptRuleCall call, @Nullable Project topProject, RelNod
RexNode compensationColumnsEquiPred = compensationPreds.left;
RexNode otherCompensationPred = compensationPreds.right;

// a. Compute final compensation predicate.
// A. Compute final compensation predicate.
if (!compensationColumnsEquiPred.isAlwaysTrue()
|| !otherCompensationPred.isAlwaysTrue()) {
// All columns required by compensating predicates must be contained
Expand Down Expand Up @@ -456,7 +459,7 @@ protected void perform(RelOptRuleCall call, @Nullable Project topProject, RelNod
ImmutableList.of(compensationColumnsEquiPred,
otherCompensationPred));

// b. Generate final rewriting if possible.
// B. Generate final rewriting if possible.
// First, we add the compensation predicate (if any) on top of the view.
// Then, we trigger the unifying method. This method will either create a
// Project or an Aggregate operator on top of the view. It will also compute
Expand Down