[CALCITE-5782] Add TO_HEX and FROM_HEX functions (enabled in BigQuery library)#3290
Merged
ILuffZhe merged 1 commit intoapache:mainfrom Jul 10, 2023
Merged
[CALCITE-5782] Add TO_HEX and FROM_HEX functions (enabled in BigQuery library)#3290ILuffZhe merged 1 commit intoapache:mainfrom
ILuffZhe merged 1 commit intoapache:mainfrom
Conversation
tanclary
reviewed
Jul 5, 2023
ILuffZhe
reviewed
Jul 6, 2023
Contributor
ILuffZhe
left a comment
ILuffZhe
left a comment
There was a problem hiding this comment.
Overall looks good! Left some minor comments.
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
Contributor
I think it looks good as well, the only thing I am confused about is the documentation question but I ask more out of curiosity. |
ILuffZhe
added
the
LGTM-will-merge-soon
Contributor
|
Hi @zoudan, could you please rebase and squash the commits? I think the PR is ready to merge. |
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.