[CALCITE-5807] Add SUBSTRING_INDEX function (enabled in Spark library)

[Rocky0714]

No description provided.

[ILuffZhe]

Left some comments. Please take a look when you are free.

[ILuffZhe]

Hi @hujianhong , left some comments.
One small tip: before the final squash and rebase, please don't force push your commit. It helps other reviewers to see the differences.

[Rocky0714]

Hi @hujianhong , left some comments. One small tip: before the final squash and rebase, please don't force push your commit. It helps other reviewers to see the differences.

I'm sorry. This is my first PR for calcite. I will be careful in the future.

[ILuffZhe]

There are some specific rules for commit message after c0e6ba2. Could you please amend yours so I can approve the following CI?

[invalid git log message 'fix and add test cases'; Message must start with upper-case letter]

[Rocky0714]

There are some specific rules for commit message after c0e6ba2. Could you please amend yours so I can approve the following CI?

[invalid git log message 'fix and add test cases'; Message must start with upper-case letter]

done

[Rocky0714]

@ILuffZhe Can you help me find out what is the reason of the CI task failed? The CI log information seem not match to my PR.

[NobiGo]

@hujianhong The CI task failure was caused by another PR and has been resolved. So don't worry.

[ILuffZhe]

@hujianhong You can refer to the Calcite Website(https://calcite.apache.org/develop/#contributing).
In the special case, that the CI build failed, and the failure is not caused by your changes create an empty commit (git commit --allow-empty) and push it.

[ILuffZhe]

LGTM! Let's see if there are any new comments come.

[ILuffZhe]

Hi @hujianhong , could you please rebase and squash your commits? I'll merge this in the next few days.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

93.2% Coverage
0.0% Duplication

[mihaibudiu]

@hujianhong if you can squash the two commits we can merge this PR. Thank you.

[mihaibudiu]

Can you please rebase and squash the commits so we can merge this PR?

[Rocky0714]

Can you please rebase and squash the commits so we can merge this PR?

Ok, I will rebase and squash.

[mihaibudiu]

The CI is unhappy, but I think there are only small changes necessary to make it pass.
If you do them, you can probably squash the commits directly.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Rocky0714]

The CI is unhappy, but I think there are only small changes necessary to make it pass. If you do them, you can probably squash the commits directly.

Done, thanks.