Conversation
site/_docs/history.md
Outdated
| The way of Locale parsing changed within [<a href="https://issues.apache.org/jira/browse/CALCITE-5567">CALCITE-5567</a>] | ||
| Now locale's language tag should match IETF BCP 47 language tag or be empty. | ||
| * [<a href="https://issues.apache.org/jira/browse/CALCITE-5823">CALCITE-5823</a>] | ||
| Remove commons-collections dependency from innodb |
There was a problem hiding this comment.
Why is this a breaking change? I though that this change is transparent to users of calcite.
There was a problem hiding this comment.
If the user uses this dependency in their project which was introduced by Calcite, We need to tell it.
| Now locale's language tag should match IETF BCP 47 language tag or be empty. | ||
| * [<a href="https://issues.apache.org/jira/browse/CALCITE-5823">CALCITE-5823</a>] | ||
| Remove commons-collections dependency from innodb | ||
| * The way of Locale parsing changed within [<a href="https://issues.apache.org/jira/browse/CALCITE-5746">CALCITE-5746</a>] |
There was a problem hiding this comment.
Missing period for the end of sentence.
site/_docs/history.md
Outdated
| This release comes 4 months after [1.34.0](#v1-34-0), | ||
| contains contributions from 36 contributors, and resolves 139 issues. | ||
|
|
||
| Among other new features, we have added extensive function support. For example, we added roughly 14 new functions in BigQuery library for handling array, dates, math, and string. |
There was a problem hiding this comment.
"we have added extensive function support" contains some redundancy. Consider making it more precise and direct: e.g., "it adds more than 40 new SQL functions in various libraries such as BigQuery and Spark."
site/_docs/history.md
Outdated
| Among other new features, we have added extensive function support. For example, we added roughly 14 new functions in BigQuery library for handling array, dates, math, and string. | ||
| Also, we added 27 new functions in Spark library for handling array, map and about 11 new functions for other database products. | ||
|
|
||
| Among other improvements and fixes, it is worth highlighting the following improvements: |
There was a problem hiding this comment.
"Among other ..." appears also in the paragraph above and sounds a bit repetitive. Consider skipping the sentence altogether.
site/_docs/history.md
Outdated
| * [<a href="https://issues.apache.org/jira/browse/CALCITE-5703">CALCITE-5703</a>] | ||
| Reduce amount of generated runtime code | ||
| * [<a href="https://issues.apache.org/jira/browse/CALCITE-5479">CALCITE-5479</a>] | ||
| FamilyOperandTypeChecker is not readily composable in sequences |
There was a problem hiding this comment.
Class names should be enclosed in backticks (`FamilyOperandTypeChecker`).
site/_docs/history.md
Outdated
|
|
||
| * Some improvements in simplify an expression. | ||
| * [<a href="https://issues.apache.org/jira/browse/CALCITE-5769">CALCITE-5769</a>] | ||
| Optimizing 'CAST(e AS t) IS NOT NULL' to 'e IS NOT NULL' |
There was a problem hiding this comment.
Instead of single quotes use backticks (`) for SQL keywords and functions. Lots of class names and SQL functions/keywords below are not properly formatted so this comment applies to the whole section.
site/_docs/history.md
Outdated
| {: #dependency-1-35-0} | ||
|
|
||
| * [<a href="https://issues.apache.org/jira/browse/CALCITE-5477">CALCITE-5477</a>] | ||
| Build with Guava 19.0 |
There was a problem hiding this comment.
This is a downgrade so maybe it is worth putting in the breaking changes section.
site/_docs/history.md
Outdated
| * [MINOR] Adjust nullableType and java doc for RexProgramBuilderBase | ||
| * [MINOR] Assert can be replaced in `AbstractMaterializedViewRule#perform()` |
There was a problem hiding this comment.
In general MINOR things should be excluded from release notes but not sure if in this case the commits are really minor. Better remove the [MINOR] prefix.
site/_docs/history.md
Outdated
| * Code style: Lint | ||
| * Code style: improve Javadoc | ||
| * Code style: disallow '))' and ').' at the start of a line | ||
| * Update javadoc for RelColumnOrigin#isDerived method |
site/_docs/history.md
Outdated
| * Code style: Lint | ||
| * Code style: improve Javadoc |
There was a problem hiding this comment.
Consider moving code style changes to build section.
There was a problem hiding this comment.
Thanks for the review. I will fix this.
4 participants
No description provided.