[CALCITE-5859] Compile-time evaluation of LEFT(NULL, n) should not throw RuntimeException#3323
Merged
asolimando merged 1 commit intoapache:mainfrom Aug 2, 2023
Merged
Conversation
Contributor
Author
|
Can this fix for a crash be merged? |
Member
|
@mihaibudiu, the patch LGTM, but maybe we can update the title of the Jira ticket (and associated the commit message) along the line of "Compile-time evaluation of LEFT(NULL, n) should not throw RuntimeException"? WDYT? |
…row RuntimeException Signed-off-by: Mihai Budiu <mbudiu@gmail.com>
mihaibudiu
changed the title
Contributor
Author
|
@asolimando updated the issue name in all places |
asolimando
approved these changes
Aug 1, 2023
Member
asolimando
left a comment
asolimando
left a comment
There was a problem hiding this comment.
Thanks @mihaibudiu for the change, LGTM, will merge 24h from now if there are no objections
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.