[CALCITE-1527] Support DML in the JDBC adapter#334
Closed
tzolov wants to merge 7 commits intoapache:masterfrom
Closed
[CALCITE-1527] Support DML in the JDBC adapter#334tzolov wants to merge 7 commits intoapache:masterfrom
tzolov wants to merge 7 commits intoapache:masterfrom
Conversation
…alcisteAssert to verify DML statements
…th the INSERT and DELETE
…ify. Required for UPDATE implementations
…atment/connection open! Convert the tests from Postgresql to HSQLDB
Contributor
Author
|
Note: [edc28ad] resolves a strange problem that i unintentionally have caused. Apparently we need to keep the |
…dress the review recomendations
ldming
pushed a commit
to ldming/mycalcite
that referenced
this pull request
Sep 13, 2018
…ger modulo N (Julian Feinauer) Close apache/calcite#339 A previous PR I forgot to close: Close apache/calcite#334
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
apache#334) …so that rule match order is deterministic across runs Co-authored-by: botong.huang <botong.huang@alibaba-inc.com>
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
apache#334) …so that rule match order is deterministic across runs Co-authored-by: botong.huang <botong.huang@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rowcountinstead ofResultSetUPDATEimplementation requires access to theSETsource expressions. WhileTableModifyprovides theSETcolumn names it misses the set value expressions. Therefore I've added a new field:List<RexNode> sourceExpressionListtoTableModify(and updated many impacted classes ) [9c8f141].The
sourceExpressionListis initialized from theSqlUpdate:It works for the common use cases but failed with update sub-queries. Check the
RelToSqlConverter#testUpdateSubQuery! I guess there is a better way to resolve the source expressions for sub-query?statement.executeQuery(sql)(inResultSetEnumerable) intoboolean isResultSetProvided = statement.execute(sql)and handle the result according to theisResultSetProvided.To Support the Insert i had to make the
JdbcTableaModifiableTable- later is marked as experimental?Also i had to lower the
JdbcTableModifycost (super.computeSelfCost(planner, mq).multiplyBy(.1)) to make it win over theEnumberableTableModify.