[CALCITE-5884] ARRAY_TO_STRING function should return NULL if its 'nullValue' argument is NULL#3346
Conversation
|
@zoudan I think you have implemented this function. |
mihaibudiu
force-pushed
the
issue5884
branch
3 times, most recently
from
a23b2fe to
b320d7d
Compare
rubenada
added
the
discussion-in-jira
|
Kudos, SonarCloud Quality Gate passed! |
|
I would appreciate if someone could review this PR. |
|
@mihaibudiu ,please rebase the latest main branch's code. |
Done |
libenchao
left a comment
libenchao
left a comment
There was a problem hiding this comment.
Thanks @mihaibudiu, it looks good to me with only nit comments. Please note that Julian has proposed a better summary in Jira.
| public static String arrayToString(List list, String delimiter, @Nullable String nullText) { | ||
| // Note that the SQL function ARRAY_TO_STRING that we implement will return | ||
| // 'NULL' when the nullText argument is NULL. However, that is handled by | ||
| // the nullPolicy of the RexToLixTranslator. So here a NULL value |
There was a problem hiding this comment.
NIT: redundant spaces (and in above line too)
There was a problem hiding this comment.
I have changed the summary, removed the spaces, and squashed the commits.
…llValue' argument is NULL Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
changed the title
|
@julianhyde I hope I have made the changes you requested |
|
Kudos, SonarCloud Quality Gate passed! |
|
Can we move on with merging, or we can leave it out of 1.36.0? I plan to start the release process if there is still no progress on this PR in a day :) |
|
I think we should just merge it. I think it's a positive improvement in documentation. |
5 participants
No description provided.