[CALCITE-6095] Arithmetic expression with VARBINARY value causes AssertionFailure#3527
[CALCITE-6095] Arithmetic expression with VARBINARY value causes AssertionFailure#3527mihaibudiu merged 1 commit intoapache:mainfrom
Conversation
| * [CALCITE-6095] Arithmetic expression with VARBINARY value causes AssertionFailure</a>. | ||
| */ | ||
| @Test public void testVarbitArithmetic() { | ||
| SqlOperatorFixture f = fixture(); |
There was a problem hiding this comment.
Would this belong better in TypeCoercionTest? I get that CAST is an operator but maybe that class is more tailored to the purpose of this ticket. Let me know what you think.
There was a problem hiding this comment.
I actually see that TypeCoercionTest has negative tests for binary in the method testImplicitCasts. So these tests are not sufficient.
The problem is in the type inference for the binary operator. The only negative tests in this file are using shouldNotCast, which does not seem to exercise the inference for binary operators.
There is an additional benefit having operator tests: we are also checking the error message. But that is less important.
mihaibudiu
force-pushed
the
issue6095
branch
from
7615fd4 to
18f8840
Compare
|
LGTM. Clear error message is an improvement compared to AssertionFailure. |
|
What is the conclusion with respect to the Druid tests? |
…rtionFailure Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
|
Kudos, SonarCloud Quality Gate passed! |
3 participants
No description provided.