[MINOR] Update javadoc for RexChecker with Litmus argument#3536
Merged
mihaibudiu merged 1 commit intoapache:mainfrom Dec 27, 2023
Merged
[MINOR] Update javadoc for RexChecker with Litmus argument#3536mihaibudiu merged 1 commit intoapache:mainfrom
mihaibudiu merged 1 commit intoapache:mainfrom
Conversation
yeahthisisrob
force-pushed
the
doc-updates
branch
from
ef9d2f6 to
9bf01af
Compare
yeahthisisrob
changed the title
mihaibudiu
reviewed
Nov 20, 2023
| * RelDataType rowType; | ||
| * RexChecker checker = new RexChecker(rowType, Litmus.IGNORE); | ||
| * node.accept(checker); | ||
| * if (!checker.isValid()) { |
Contributor
There was a problem hiding this comment.
The original javadoc had two examples, whereas here there is only one.
I do find that the assert-based example is useful.
Contributor
Author
There was a problem hiding this comment.
Thanks, I completely missed the first example. I recently used IGNORE and was focused there. Updated!
Contributor
|
Remove 'Fix:' from the commit message. That's not a prefix we use in this project. |
yeahthisisrob
force-pushed
the
doc-updates
branch
from
9bf01af to
8b5a612
Compare
yeahthisisrob
changed the title
mihaibudiu
approved these changes
Nov 21, 2023
Contributor
|
@yeahthisisrob , Would you please add |
yeahthisisrob
force-pushed
the
doc-updates
branch
from
8b5a612 to
cbdd0b2
Compare
yeahthisisrob
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the javadoc for
RexCheckerto reflect changes from https://issues.apache.org/jira/browse/CALCITE-955