Closed
Conversation
etherge
reviewed
Jan 23, 2017
| } | ||
|
|
||
| @Override public MemberExpression field(Expression expression, int field, | ||
| Type fromType, Type fieldType) { |
There was a problem hiding this comment.
Why this newly added method has totally same codes with above method?
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Jan 23, 2017
… Wang) Date condition currently generates Integer == Integer, which is always false. Review comments from Julian Hyde: The fix isn't ideal. I'd rather that we convert java.sql.Date values when they enter the system. And, if we allow java.sql.Date values then we should treat java.util.Date, java.sql.Time and java.sql.Timestamp values similarly. But, being pragmatic, I'm going to accept the patch because it fixes cases that didn't work previously. If we see further problems in this area, we might back out the changes and do it properly. Close apache#356
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Jan 23, 2017
… Wang) Date condition currently generates Integer == Integer, which is always false. Review comments from Julian Hyde: The fix isn't ideal. I'd rather that we convert java.sql.Date values when they enter the system. And, if we allow java.sql.Date values then we should treat java.util.Date, java.sql.Time and java.sql.Timestamp values similarly. But, being pragmatic, I'm going to accept the patch because it fixes cases that didn't work previously. If we see further problems in this area, we might back out the changes and do it properly. Close apache#356
ldming
pushed a commit
to ldming/mycalcite
that referenced
this pull request
Sep 13, 2018
… Wang) Date condition currently generates Integer == Integer, which is always false. Review comments from Julian Hyde: The fix isn't ideal. I'd rather that we convert java.sql.Date values when they enter the system. And, if we allow java.sql.Date values then we should treat java.util.Date, java.sql.Time and java.sql.Timestamp values similarly. But, being pragmatic, I'm going to accept the patch because it fixes cases that didn't work previously. If we see further problems in this area, we might back out the changes and do it properly. Close apache/calcite#356
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
Co-authored-by: Haisheng Yuan <h.yuan@alibaba-inc.com>
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
Co-authored-by: Haisheng Yuan <h.yuan@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CALCITE-1569 fix dates can join with comparison