[CALCITE-6179] Support weekofmonth function format and add test

[caicancai]

https://issues.apache.org/jira/browse/CALCITE-6179

[caicancai]

Is the result of format affected by the jdk version?
https://github.com/apache/calcite/actions/runs/7330705153/job/19962233529

[macroguo-ghy]

You need to log a JIRA case, because you have added new features.

[caicancai]

You need to log a JIRA case, because you have added new features.

Thank you for your reply

[macroguo-ghy]

Utilities for FormatModel in org.apache.calcite.util.format.FormatModels should be taken into consideration.

[caicancai]

@macroguo-ghy If you have time, can you help review my code? Thank you.

[macroguo-ghy]

@caicancai Did you miss my previous comment? I think you should add week of month to Format model for PostgreSQL. Please refer org.apache.calcite.util.format.FormatModels#POSTGRESQL and https://www.postgresql.org/docs/current/functions-formatting.html.

[caicancai]

@caicancai Did you miss my previous comment? I think you should add week of month to Format model for PostgreSQL. Please refer org.apache.calcite.util.format.FormatModels#POSTGRESQL and https://www.postgresql.org/docs/current/functions-formatting.html.

@macroguo-ghy I didn't seem to understand it before, I'm sorry about that, I understand it now, thank you for your reivew

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[macroguo-ghy]

+1

[caicancai]

@macroguo-ghy @mihaibudiu Good to merge？

[caicancai]

Thank you for the review