Skip to content

[CALCITE-6256] Incorrect rendering of HTML on InnoDB adapter page#3679

Merged
julianhyde merged 3 commits intoapache:mainfrom
strongduanmu:dev-0208
Feb 9, 2024
Merged

[CALCITE-6256] Incorrect rendering of HTML on InnoDB adapter page#3679
julianhyde merged 3 commits intoapache:mainfrom
strongduanmu:dev-0208

Conversation

@strongduanmu
Copy link
Member

The new rendered HTML is as follows(IDEA Local preview without CSS style).

image

@julianhyde
Copy link
Contributor

Seems to fix the problem.

I think that the "mysqldump -d -u<username> -p<password> -h <hostname> <dbname>" line would be better as its own code box, rather than inline; can you change it to use the highlight markup?

We don't allow commit messages with the word 'fix'. Can you change the commit message to match the jira case summary.

@strongduanmu
Copy link
Member Author

@julianhyde Thank you for your advice, I will modify this pr.

@strongduanmu strongduanmu changed the title [CALCITE-6256] Fix incorrect rendering of HTML on InnoDB adapter page [CALCITE-6256] Correct incorrect rendering of HTML on InnoDB adapter page Feb 9, 2024
@julianhyde
Copy link
Contributor

You changed 'Fix' to 'Correct' in the commit message. Instead, can you change the commit message to the jira case summary? (If a commit message describes a bug, it is implied that the commit fixes the bug.)

@strongduanmu
Copy link
Member Author

Thank you very much for your guidance. I will pay attention to these norms of the Calcite community so that my next contribution can be more perfect.

@strongduanmu strongduanmu changed the title [CALCITE-6256] Correct incorrect rendering of HTML on InnoDB adapter page [CALCITE-6256] Incorrect rendering of HTML on InnoDB adapter page Feb 9, 2024
@julianhyde julianhyde merged commit 80f96bb into apache:main Feb 9, 2024
@strongduanmu strongduanmu deleted the dev-0208 branch February 9, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants