[CALCITE-6256] Incorrect rendering of HTML on InnoDB adapter page#3679
Merged
julianhyde merged 3 commits intoapache:mainfrom Feb 9, 2024
Merged
[CALCITE-6256] Incorrect rendering of HTML on InnoDB adapter page#3679julianhyde merged 3 commits intoapache:mainfrom
julianhyde merged 3 commits intoapache:mainfrom
Conversation
Contributor
|
Seems to fix the problem. I think that the " We don't allow commit messages with the word 'fix'. Can you change the commit message to match the jira case summary. |
Member
Author
|
@julianhyde Thank you for your advice, I will modify this pr. |
Contributor
|
You changed 'Fix' to 'Correct' in the commit message. Instead, can you change the commit message to the jira case summary? (If a commit message describes a bug, it is implied that the commit fixes the bug.) |
Member
Author
|
Thank you very much for your guidance. I will pay attention to these norms of the Calcite community so that my next contribution can be more perfect. |
julianhyde
approved these changes
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new rendered HTML is as follows(IDEA Local preview without CSS style).