CALCITE-1659: use precision instead of scale for timestamp in makeCast#384
Closed
rusanu wants to merge 1 commit intoapache:masterfrom
Closed
CALCITE-1659: use precision instead of scale for timestamp in makeCast#384rusanu wants to merge 1 commit intoapache:masterfrom
rusanu wants to merge 1 commit intoapache:masterfrom
Conversation
…der.makeCast Make ZonelessTimestamp digest contain relevant sub-second fraction. Add UT
ldming
pushed a commit
to ldming/mycalcite
that referenced
this pull request
Sep 13, 2018
…P) should round the sub-second fraction (Remus Rusanu) Previously the code incorrectly used the type's scale; now it uses the type's precision. Make ZonelessTimestamp digest contain relevant sub-second fraction. Close apache/calcite#384
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.