[CALCITE-6296] Support IS NULL in Arrow adapter

[timgrein]

Add the unary isnull Gandiva operator to ArrowTranslator.

[asolimando]

LGTM

Edit: there seems to a problem with Sonar in CI which doesn't look like a transient failure, can you take a look @timgrein? Did you experience any issues locally?

[timgrein]

Edit: there seems to a problem with Sonar in CI which doesn't look like a transient failure, can you take a look @timgrein? Did you experience any issues locally?

I couldn't reproduce it locally. I ran the following commands:

./gradlew clean ':arrow:test' --no-build-cache

and

./gradlew build. Any other commands you want to share, which might be helpful to investigate this? @asolimando

Both succeeded without the issue from CI, I'll check, if it appears again.

[caicancai]

Edit: there seems to a problem with Sonar in CI which doesn't look like a transient failure, can you take a look @timgrein? Did you experience any issues locally?

I couldn't reproduce it locally. I ran the following commands:

./gradlew clean ':arrow:test' --no-build-cache

and

./gradlew build. Any other commands you want to share, which might be helpful to investigate this? @asolimando

Both succeeded without the issue from CI, I'll check, if it appears again.

You can look at the cli log.
Integration/jenkins/pr-head may occasionally fail. If the log exception is not very strange, I think this will not affect the merge.

[timgrein]

Edit: there seems to a problem with Sonar in CI which doesn't look like a transient failure, can you take a look @timgrein? Did you experience any issues locally?

I couldn't reproduce it locally. I ran the following commands:
./gradlew clean ':arrow:test' --no-build-cache
and
./gradlew build. Any other commands you want to share, which might be helpful to investigate this? @asolimando
Both succeeded without the issue from CI, I'll check, if it appears again.

You can look at the cli log. Integration/jenkins/pr-head may occasionally fail. If the log exception is not very strange, I think this will not affect the merge.

Thanks for the context! Seems like it succeeded now.

[asolimando]

Few minor changes emerged during review, let's address them, but they are minor and we are converging

[timgrein]

Few minor changes emerged during review, let's address them, but they are minor and we are converging

Thanks for the detailed review @asolimando, already helped a lot! Addressed your changes, let me know, if there's something else.

[caicancai]

Mostly looks good, just a few minor comments

[asolimando]

LGTM, one final nitpick but it's optional, all other comments seem to have been addressed.

[caicancai]

LGTM

[asolimando]

If @NobiGo is fine as well with the current status of the PR, I will ask you @timgrein to squash everything into a single commit and I will then merge. Please wait for the final confirmation before squashing as it makes incremental reviewing way harder, thanks!

[asolimando]

@timgrein, can you please squash the commits into a single one, having "[CALCITE-6296] Support IS NULL in Arrow adapter" as commit message? After that I will merge, thanks!

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
81.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud