[CALCITE-6483] Enable LEN and LENGTH in the correct function libraries

[normanj-bitquill]

Enabled the LEN function for:

• Amazon Redshift
• Snowflake
• Spark

Enabled the LENGTH function for:

• BigQuery
• Hive
• PostgreSQL
• Amazon Redshift
• Snowflake
• Spark

[caicancai]

Should we add tests to SqlOperatorTest?

[rubenada]

Should we add tests to SqlOperatorTest?

@caicancai I think there is no need to touch SqlOperatorTest. The way that class works, the already existing tests testLenFunc and testLengthFunc will automatically consider the libraries in the @LibraryOperator annotation of LEN and LENGTH (including the newly added ones). So new checks are added transparently for the new libraries.

[rubenada]

@normanj-bitquill overall LGTM. I think that current patch is wider than the original intent, so perhaps we should adjust the Jira title (and commit message) to something broader, e.g. "Add LEN and LENGTH functions to missing libraries", wdyt?

[caicancai]

@normanj-bitquill overall LGTM. I think that current patch is wider than the original intent, so perhaps we should adjust the Jira title (and commit message) to something broader, e.g. "Add LEN and LENGTH functions to missing libraries", wdyt?

@rubenada Thank you for your reply. I am worried that in some negative tests, the results of each dialect may be different. Do you mind if I test it on some databases first?

[caicancai]

LGTM, I test negative test

[normanj-bitquill]

@rubenada I have updated the ticket title and commit message. Let me know if it still doesn't match the change.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[rubenada]

LGTM

[rubenada]

Thanks @normanj-bitquill , LGTM. I'll merge in the next 24-48h if no further comment appears.