[Calcite-1665] Aggregates and HAVING cannot be combined#388
Closed
Zhiqiang-He wants to merge 3 commits intoapache:masterfrom
Closed
[Calcite-1665] Aggregates and HAVING cannot be combined#388Zhiqiang-He wants to merge 3 commits intoapache:masterfrom
Zhiqiang-He wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
Looks good (although I haven't run the tests). Can you keep the indentation the same? Your indentation change might be introducing spurious diffs. |
Zhiqiang-He
force-pushed
the
calcite-1665
branch
from
d6024c8 to
5de6f1e
Compare
Contributor
Author
|
indentation already change in test case . please review it. thanks. |
jbalint
reviewed
Mar 9, 2017
| } else { | ||
| final Builder builder = x.builder(e, Clause.WHERE); | ||
| builder.setWhere(builder.context.toSql(null, e.getCondition())); | ||
| if (input instanceof Join) { |
Member
There was a problem hiding this comment.
Why did you add this condition and new result(boolean) method? All tests are passing without it.
Contributor
Author
There was a problem hiding this comment.
Sorry, It's my mistake, I am alias test on reltosql for calcite now.
this function will be removed.
Zhiqiang-He
force-pushed
the
calcite-1665
branch
from
d8aaa9d to
a431507
Compare
Contributor
Author
|
@jbalint Please review it . thanks. |
ldming
pushed a commit
to ldming/mycalcite
that referenced
this pull request
Sep 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.