[CALCITE-6471] Improve performance of SqlToRelConverter by preventing unconditional conversion of sqlNodes to string for null-check messages #3884
Merged
asolimando merged 1 commit intoapache:mainfrom Aug 8, 2024
Conversation
mihaibudiu
approved these changes
Jul 25, 2024
mihaibudiu
added
the
LGTM-will-merge-soon
caicancai
approved these changes
Jul 26, 2024
Contributor
|
Can you please update the commit message to match the JIRA subject? |
mihaibudiu
changed the title
Contributor
Author
|
Folks, thank you all for review! I've got 3 approvals from reviewers as well as one from sonarcloud. Also it has label |
Member
|
@korlov42, can you update the (single) commit message to match the updated title of the Jira ticket? After that I think we can merge the PR. |
… unconditional conversion of sqlNodes to string for null-check messages
Contributor
Author
|
@asolimando , done. I've also rebased my branch on latest main. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-6471
This patch replaces all unconditional conversions of SqlNode to string in SqlToRelConverter with on-demand message suppliers for null checks (
requireNonNull).