[CALCITE-6502] Parser loses position information for Expression3#3886
Merged
mihaibudiu merged 1 commit intoapache:mainfrom Jul 30, 2024
Merged
[CALCITE-6502] Parser loses position information for Expression3#3886mihaibudiu merged 1 commit intoapache:mainfrom
mihaibudiu merged 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
caicancai
reviewed
Jul 26, 2024
| if (list1.size() == 1) { | ||
| // interpret as single value or query | ||
| return list1.get(0); | ||
| return list1.get(0).clone(list1.getParserPosition()); |
Contributor
Author
There was a problem hiding this comment.
this is actually the line that fixes the JIRA bug
caicancai
approved these changes
Jul 26, 2024
NobiGo
reviewed
Jul 29, 2024
NobiGo
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was another bug in the parsing of array ITEM operators, which was uncovered by this fix.