[CALCITE-6543] Change the RelOptCostImpl toString method to be consistent with VolcanoCost#3930
Conversation
|
I think this PR deserves a jira case |
Ok, thanks for reviewing the code for me |
31f4ac2 to
89df8e0
Compare
Hello, jira has been created |
89df8e0 to
596530f
Compare
| @Override public String toString() { | ||
| if (value == Double.MAX_VALUE) { | ||
| return "huge"; | ||
| } else if (value == Double.POSITIVE_INFINITY) { |
There was a problem hiding this comment.
It would be best to have a test example to illustrate
There was a problem hiding this comment.
Ok, thanks for reviewing the code for me
|
Ideally you should avoid code duplication, especially when the control-flow is so complicated. |
Ok, thank you for helping me review the code, I will modify this place |
…tent with VolcanoCost
596530f to
d2d0c5a
Compare
Hello, the modified code has been submitted. If there is any problem, I will modify it again |
|
|
@ChengJie1053 You should not squash. Wait until no one else has any comments, then squash. We need to know what you changed in each commit, so that it is better to review. |
Ok, thank you. I mistakenly thought that every commit requires a squash commit. I will pay attention to that in the future |



Uh oh!
There was an error while loading. Please reload this page.