[CALCITE-6549] Add LOG1P function (enabled in Spark library)#3934
[CALCITE-6549] Add LOG1P function (enabled in Spark library)#3934caicancai wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
@NobiGo PTAL, thanks |
| @@ -4292,18 +4294,27 @@ private static List<Expression> args(RexCall call, | |||
| operand0 = operands.left; | |||
| operand1 = operands.right; | |||
| boolean nonPositiveIsNull = library == SqlLibrary.MYSQL ? true : false; | |||
There was a problem hiding this comment.
We should pass the library as the Parameter. Then the code logic will be clear. WDYT?
There was a problem hiding this comment.
Maybe we should refactor the code in another issue. The current code here has poor extensibilit.
There was a problem hiding this comment.
Yes, I have to admit this. https://issues.apache.org/jira/browse/CALCITE-6550 is already working on this. I'll close it first.
There was a problem hiding this comment.
@NobiGo Could you please post your opinion at https://issues.apache.org/jira/browse/CALCITE-6550? I think it is a very complicated issue.
There was a problem hiding this comment.
I don't think you should pass in a library at run time. The runtime should not be worrying about high-level concepts like llibrary.
3 participants
https://issues.apache.org/jira/browse/CALCITE-6549