[CALCITE-6374] LatticeSuggester throw NullPointerException when agg c…#3963
Merged
Conversation
caicancai
reviewed
Sep 12, 2024
| /** Test case for | ||
| * <a href="https://issues.apache.org/jira/browse/CALCITE-6374">[CALCITE-6374] | ||
| * LatticeSuggester throw NullPointerException when agg call covered with cast </a>. */ | ||
| @Test void testCastExpression() throws Exception { |
Member
There was a problem hiding this comment.
Maybe the name testCastExpression is not clear enough. Is there a clearer way to use it?
Contributor
Author
There was a problem hiding this comment.
Adjusted test method name.
YiwenWu
force-pushed
the
CALCITE-6374
branch
from
aeaf015 to
494f81a
Compare
macroguo-ghy
approved these changes
Sep 21, 2024
Contributor
macroguo-ghy
left a comment
macroguo-ghy
left a comment
There was a problem hiding this comment.
looks good, please squash your commits
…all covered with cast
YiwenWu
force-pushed
the
CALCITE-6374
branch
from
956b6f1 to
a72e774
Compare
Contributor
Author
|
@macroguo-ghy thank you for the review, I have squashed commits. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…all covered with cast
https://issues.apache.org/jira/browse/CALCITE-6374
Ensure that the
namefield ofMutableMeasureis not empty. Ifnameis empty, an alias will be automatically generated.