[CALCITE-6584] Validate prefixed column identifiers in SET clause of UPDATE statement#3972
Closed
nielspardon wants to merge 1 commit intoapache:mainfrom
Closed
[CALCITE-6584] Validate prefixed column identifiers in SET clause of UPDATE statement#3972nielspardon wants to merge 1 commit intoapache:mainfrom
nielspardon wants to merge 1 commit intoapache:mainfrom
Conversation
…UPDATE statement Signed-off-by: Niels Pardon <par@zurich.ibm.com>
nielspardon
force-pushed
the
par-6584
branch
from
e021071 to
dc3cea6
Compare
|
mihaibudiu
approved these changes
Sep 21, 2024
mihaibudiu
reviewed
Sep 21, 2024
| @Test void testAliasInSetClauseOfUpdate() { | ||
| // good examples | ||
| sql("UPDATE sales.emp AS e SET e.deptno = 10").ok(); | ||
| sql("UPDATE emp AS e SET e.deptno = 10").ok(); |
Contributor
There was a problem hiding this comment.
postgres actually rejects this: Query Error: error: column "e" of relation "emp" does not exist
julianhyde
added a commit
to julianhyde/calcite
that referenced
this pull request
Sep 24, 2024
Close apache#3972
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
…UPDATE statement Signed-off-by: Niels Pardon <par@zurich.ibm.com> Close #3972
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds validation of prefixed column identifiers in SET clause of UPDATE statement (and in the UPDATE statement within a MERGE statement)
SqlValidatorUtil.addFields()to use theUtil.last()method for getting the last element of a compound identifier instead of relying on simple identifiersSqlValidatorImpl.createTargetRowType()which is being used for validating INSERT, UPDATE and MERGEtargetTableAliasparameter the validation logic checks the prefix of any non-simple identifiers or in other words it checks that any prefixed column identifiers are prefixed with the target table aliasLet me know your thoughts.