[CALCITE-6633] Add CEILING to MSSQL dialect#4008
Merged
mihaibudiu merged 1 commit intoapache:mainfrom Oct 18, 2024
Merged
Conversation
mihaibudiu
approved these changes
Oct 17, 2024
mihaibudiu
added
the
LGTM-will-merge-soon
NobiGo
approved these changes
Oct 18, 2024
Contributor
NobiGo
left a comment
NobiGo
left a comment
There was a problem hiding this comment.
LGTM. Only left some minor advice in Jira to improve the summary and description.
caicancai
approved these changes
Oct 18, 2024
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Show resolved
Hide resolved
Contributor
|
If the CI passes, please squash the commits so we can merge the PR. |
Contributor
|
the style checker is unhappy about your formatting. |
Indentation and minor changes. [CALCITE-6633] Add CEILING to MSSQL dialect Add Jira link to test. [CALCITE-6633] Add CEILING to MSSQL dialect Add CEILING to MSSQL dialect
Contributor
Author
I completed the changes to formatting. |
|
Contributor
|
I have changed the JIRA title to match the PR and commit subject |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid unparse for CEIL in MssqlSqlDialect